Upgrade to styled-components v5

[dcastil]

🎉

Release: https://github.com/styled-components/styled-components/releases/tag/v5.0.0
Migration docs: https://styled-components.com/docs/faqs#what-do-i-need-to-do-to-migrate-to-v5

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

gatsby-theme-primer-example – ./

🔍 Inspect: https://vercel.com/primer/gatsby-theme-primer-example/577usy82d
✅ Preview: https://gatsby-theme-primer-example-git-styled-components-v5.primer.now.sh

doctocat – ./

🔍 Inspect: https://vercel.com/primer/doctocat/bvx9y6qyp
✅ Preview: https://doctocat-git-styled-components-v5.primer.now.sh

[dcastil]

Hmmm could someone tell me what made the deployment fail? I don't have permission to access the build logs unfortunately.

[colebemis]

Thanks for taking this on, @dcastil! 🎉

It looks like this update broke live preview iframes:

My best guess is that the problem is with the StyleSheetManager used in the Frame component: https://github.com/primer/doctocat/blob/master/theme/src/components/frame.js

@mxstbr Did StyleSheetManager at all in the v5 release?

[dcastil]

Damn, I didn't even notice. Thanks for investigating, @colebemis! Seems like some styles are applied and some not. I'll try to figure it out. But there shouldn't be any breaking changes to the StylesheetManager, it might be a bug in styled-components.

[dcastil]

The StylesheetManager fix styled-components/styled-components#3159 was merged just now. Looks like we can make the upgrade happen after the next release of styled-components. 😊

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3ea9e6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[dcastil]

The StylesheetManager issue was fixed in styled-components@5.2.0. I checked the deployment on Vercel and looks good!

[mxstbr]

~10% faster! 😍

[github-actions]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.