Button: Add clarification on selections #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximedegreve
temporarily deployed
to
github-pages
GitHub Actions
Inactive
maximedegreve
temporarily deployed
to
github-pages
GitHub Actions
Inactive
maximedegreve
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mperrotti
reviewed
Apr 30, 2024
content/components/button.mdx
Outdated
| @@ -428,6 +428,39 @@ Limit primary button usage. Only use one primary button on the page, whenever po | |||
| </Dont> | |||
| </DoDontContainer> | |||
|
|
|||
| ### Selections | |||
|
|
|||
| Buttons are commonly used to show a choice within a `select`, [SelectPanel](/components/selectpanel) or [ActionMenu](/components/action-menu). In such instances, they are frequently paired with an internal or external label. | |||
There was a problem hiding this comment.
to show a choice within a
select
When do we use a button to show the selections from a select?
There was a problem hiding this comment.
Oops that was wrong. Removed it. 🙂
maximedegreve
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Co-authored-by: Mike Perrotti <mperrotti@github.com>
mperrotti
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following some confusion in Slack (internally) regarding the display of multiple selections within our buttons, we convened to discuss and concluded that documenting this would be beneficial.