Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component refresh tweaks 9 #1109

Merged
merged 3 commits into from
Jun 17, 2020
Merged

Component refresh tweaks 9 #1109

merged 3 commits into from
Jun 17, 2020

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jun 17, 2020

Here a few more tweaks to the component refresh.

  1. Labels are a bit more bold. 400 -> 500. Now matches .Counter:
Before After
Screen Shot 2020-06-17 at 16 14 56 Screen Shot 2020-06-17 at 16 15 04
  1. Selected UnderlineNav items are now bold. 400 -> 600:
Before After
Screen Shot 2020-06-17 at 19 49 35 Screen Shot 2020-06-17 at 19 50 04
  1. Buttons have a slightly darker border. 12% -> 15% black:
Before After
Screen Shot 2020-06-17 at 19 51 37 Screen Shot 2020-06-17 at 19 51 46

@simurai simurai requested a review from auareyou June 17, 2020 10:55
@vercel
Copy link

vercel bot commented Jun 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-css/j1o98tlz0
✅ Preview: https://primer-css-git-next-9.primer.vercel.app

@simurai simurai added this to 🚧 Work in Progress in 📦 Primer CSS release tracking via automation Jun 17, 2020
@simurai simurai moved this from 🚧 Work in Progress to 🔍 Ready to release in 📦 Primer CSS release tracking Jun 17, 2020
📦 Primer CSS release tracking automation moved this from 🔍 Ready to release to ✅ Approved for release Jun 17, 2020
auareyou
auareyou approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@auareyou auareyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@simurai simurai merged commit c882f78 into next Jun 17, 2020
📦 Primer CSS release tracking automation moved this from ✅ Approved for release to 💜 Done Jun 17, 2020
@simurai simurai deleted the next-9 branch June 17, 2020 11:05
@simurai simurai mentioned this pull request Jul 2, 2020
Merged
7 tasks
@github-actions github-actions bot mentioned this pull request Dec 13, 2022
Open
@github-actions github-actions bot mentioned this pull request Dec 21, 2022
Open
@github-actions github-actions bot mentioned this pull request Dec 29, 2022
Open
This was referenced Jan 8, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auareyou auareyou auareyou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
📦 Primer CSS release tracking
💜 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simurai @auareyou