Component refresh tweaks III #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-css/akk8brezm |
simurai
added this to 🚧 Work in Progress
in 📦 Primer CSS release tracking
via automation
simurai
moved this from 🚧 Work in Progress
to 🔍 Ready to release
in 📦 Primer CSS release tracking
jonrohan
reviewed
Apr 2, 2020
| <span class="Counter Counter--small mr-1 Counter--gray">456</span> | ||
| <span class="Counter Counter--small mr-1">1.5K</span> | ||
| ``` | ||
|
|
There was a problem hiding this comment.
I see you deleting the docs here, but I didn't see Counter--small deleted in the css. Missed or already deleted before?
There was a problem hiding this comment.
Yep, the .Counter--small doesn't exist anymore and I just forgot to remove it from the docs. We might can consider adding a .Counter--large if we ever need it.
📦 Primer CSS release tracking
automation
moved this from 🔍 Ready to release
to ✅ Approved for release
Apr 2, 2020
jonrohan
approved these changes
Apr 2, 2020
📦 Primer CSS release tracking
automation
moved this from ✅ Approved for release
to 💜 Done
Apr 2, 2020
This was referenced Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here a few more "Component refresh" tweaks
Buttons
There are some changes to the primary and outline buttons:
Before
After
Sizes
This PR also reverts using only line-height for setting a component's height and instead uses again a mix of line-height and padding (and border). There are some places on dotcom that use custom padding and would blow them up too much with a large line-height.
The buttons are still only
32pxin height (instead of34px) so it matches our sizing scale. It leaves the line-height unchanged to20pxbut uses5pxy-padding instead of6px.👀 Preview