More "component refresh" tweaks #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-css/5391nz7bw |
simurai
added this to 🚧 Work in Progress
in 📦 Primer CSS release tracking
via automation
📦 Primer CSS release tracking
automation
moved this from 🚧 Work in Progress
to ✅ Approved for release
Mar 11, 2020
📦 Primer CSS release tracking
automation
moved this from ✅ Approved for release
to 💜 Done
Mar 11, 2020
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few more changes to the "component refresh".
Navigation
The orange of the
menu,UnderlineNavandSideNavslightly changed:orange-500#f9826c$orange-000#fff2f0UnderlineNav
It should also fix the dark border on page load.
Might be caused because there is a transparent border with a transition. Which initially transitions from
initial(black) totransparent. The fix is to use argba()instead oftransparent.Labels
The
.Labels now use$font-weight-normal.font-weight: 500;font-weight: 400;/cc @primer/ds-core