Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh navigation #1038

Merged
merged 13 commits into from Feb 26, 2020
Merged

Refresh navigation #1038

merged 13 commits into from Feb 26, 2020

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Feb 25, 2020

This updates the navigation components.

Screen Shot 2020-02-25 at 5 13 33 PM

👀 Preview navigation + pagination

It's probably not the final version, but maybe ok to start testing on dotcom.

TODO

  • Update docs
  • Update styles

API changes

There should be no breaking changes.

  • .Counter--small got removed again and the .Counter is now smaller by default.

/cc @primer/ds-core

@simurai simurai added this to 🚧 Work in Progress in 📦 Primer CSS release tracking via automation Feb 25, 2020
@vercel
Copy link

vercel bot commented Feb 25, 2020 •
edited

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/9nn4y5pre
✅ Preview: https://primer-css-git-next-nav.primer.now.sh

@vercel vercel bot temporarily deployed to Preview February 25, 2020 08:30 Inactive
@vercel vercel bot temporarily deployed to Preview February 25, 2020 08:35 Inactive
@simurai simurai changed the title Refreshed navigation Refresh navigation Feb 25, 2020
@simurai simurai moved this from 🚧 Work in Progress to 🔍 Ready to release in 📦 Primer CSS release tracking Feb 25, 2020
@simurai
Copy link
Contributor Author

simurai commented Feb 25, 2020

The .menu and .SideNav are kept similar. SideNav has light gray background and is typically used without any padding around.

.menu .SideNav
Screen Shot 2020-02-25 at 5 49 13 PM Screen Shot 2020-02-25 at 5 49 34 PM

colebemis
colebemis approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

📦 Primer CSS release tracking automation moved this from 🔍 Ready to release to ✅ Approved for release Feb 25, 2020
@vercel vercel bot temporarily deployed to Preview February 26, 2020 12:46 Inactive
@vercel vercel bot temporarily deployed to Preview February 26, 2020 12:49 Inactive
@simurai simurai merged commit f5d2e10 into next Feb 26, 2020
📦 Primer CSS release tracking automation moved this from ✅ Approved for release to 💜 Done Feb 26, 2020
@simurai simurai deleted the next-nav branch February 26, 2020 12:54
@simurai simurai mentioned this pull request Jul 2, 2020
Merged
7 tasks
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
This was referenced Dec 15, 2022
Open
Open
Open
This was referenced Dec 27, 2022
Open
Open
This was referenced Jan 5, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colebemis colebemis colebemis approved these changes

@auareyou auareyou Awaiting requested review from auareyou

@emplums emplums Awaiting requested review from emplums

Assignees
No one assigned
Labels
None yet
Projects
No open projects
📦 Primer CSS release tracking
💜 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simurai @colebemis