Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logosuite #582

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add logosuite #582

wants to merge 2 commits into from

Conversation

rezrah
Copy link
Collaborator

@rezrah rezrah commented Apr 25, 2024

Summary

Adds logosuite to f2 template

馃敆 See slack for full details

Resolves https://github.com/github/primer/issues/3098

List of notable changes:

  • adds logosuite to F2 templates

What should reviewers focus on?

  • Verify correct placement and surrounding placement

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • New visual snapshots have been generated / updated for any UI changes
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

馃敆 See slack for full details

Copy link

changeset-bot bot commented Apr 25, 2024

鈿狅笍 No Changeset found

Latest commit: 9aec149

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 25, 2024

馃煝 No design token changes found

Copy link
Contributor

github-actions bot commented Apr 25, 2024

馃煝 No visual differences found

Our visual comparison tests did not find any differences in the UI.

Copy link
Contributor

@auareyou auareyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants