-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hero a11y Updates #336
base: main
Are you sure you want to change the base?
Hero a11y Updates #336
Conversation
🦋 Changeset detectedLatest commit: 8c9d649 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
|
.changeset/silent-trainers-guess.md
Outdated
|
||
- Removed unnecessary `aria-labeledby` on the section component | ||
- Removed the related `id` on the heading component | ||
- Removed `br` from Hero feature story which is inaccessible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one can be removed, as it doesn't affect package output
- Removed `br` from Hero feature story which is inaccessible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in SHA
.changeset/silent-trainers-guess.md
Outdated
- Removed unnecessary `aria-labeledby` on the section component | ||
- Removed the related `id` on the heading component | ||
- Removed `br` from Hero feature story which is inaccessible | ||
- Updated `button` text in hero story to be more descriptive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with this one, as it doesn't affect package output
- Updated `button` text in hero story to be more descriptive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in SHA
1d59175
to
14239eb
Compare
Summary
A collection of changes requested from the a11y sign off review.
List of notable changes:
br
from the heading in the codespace story because it is inacessibleWhat should reviewers focus on?
Steps to test:
Contributor checklist:
Reviewer checklist:
Links: