Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chips): prevent duplicate input on korean #5449 #5626

Closed
wants to merge 3 commits into from

Conversation

KumJungMin
Copy link

Defect Fixes

Before

  • When i typing korean at chips components, the chip is created twice.
  • Because, while typing korean, the keyboard event is trigger KeyCode 229.
2024-04-22.2.06.59.mov

After

  • So, if add early return on keydown event.
  • This bug can be fixed :)
2024-04-22.2.15.14.mov

Links

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2024 11:55am
primevue-v4 ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2024 11:55am

@KumJungMin KumJungMin changed the title fix(chips): prevent duplicate input on korean fix(chips): prevent duplicate input on korean #5449 Apr 25, 2024
@KumJungMin KumJungMin closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant