feat: uniqueId mixin #5567
Open
feat: uniqueId mixin #5567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
i7slegend
force-pushed
the
feat/unique-id-mixin
branch
from
4ac9cce
to
5da4c69
Compare
i7slegend
commented
Apr 16, 2024
| @@ -196,10 +196,6 @@ export default { | |||
| type: String, | |||
| default: null | |||
| }, | |||
| id: { | |||
There was a problem hiding this comment.
Was been dummy prop only for compute d_id (for a11y) in Calendar.vue: https://github.com/primefaces/primevue/pull/5567/files#diff-29f5ad83722c320c17555abd43c32dc15aa18759ca1894c22c6e1ea53d365bbaL548
mertsincan
added
the
Status: Discussion
|
Good job, @i7slegend! This is exactly what I wanted to do in v4. Currently, I'm working on v4.beta.2 release. I'll review this PR in more detail after beta.2. |
|
Many hydration issue in console. Thanks @i7slegend. Waiting for the merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Half-duplicate of #5486
#5486 not SSR-friendly (hydration warnings), so i could not find best way for Nuxt.
This MR implements uniqueId mixin (with UniqueComponentId under hood). This mixin uses mounted hook for SSR (like it was before my requests) but for not-SSR calculate unique id before mount that remove redudant re-render (bcz id changes after mount and this trigger re-render for component and his children in the dom tree).
New file:
components/lib/utils/UniqueIdMixinFactory.js(placed in primevue/utils). Nuxt is detect by this condition:typeof window === 'undefined' || (typeof process !== 'undefined' && Boolean(process.client || process.server));