Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5167 - Dropdown: panel closes while typing Japanese #5168

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix #5167 - Dropdown: panel closes while typing Japanese #5168

wants to merge 3 commits into from

Conversation

suntel-nagamine
Copy link

###Defect Fixes
Fix #5167 - Dropdown: panel closes while typing Japanese

###Feature Requests
Fixed so that the panel does not close even if the Japanese input is confirmed (Enter).

@vercel Vercel
Copy link

vercel bot commented Jan 29, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 10:10am
primevue-v4 ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 10:10am

@tugcekucukoglu
Copy link
Member

keyCode is deprecated according to https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode

Do you have another solution?

@tugcekucukoglu tugcekucukoglu added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Mar 15, 2024
@suntel-nagamine
Copy link
Author

I wrote event.keyCode === 229 because it is indicated by https://developer.mozilla.org/en-US/docs/Web/API/Element/keydown_event.

It is believed that the latest browsers can make the decision using only event.isComposing, so if you do not consider older browsers, you may be able to make the decision using only event.isComposing.

@suntel-nagamine
Copy link
Author

Sorry for the late response.
Deleting the keyCode did not seem to cause any problems, so I deleted it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dropdown: panel closes while typing Japanese
2 participants
@suntel-nagamine @tugcekucukoglu