Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown: panel closes while typing Japanese #5167

Open
suntel-nagamine opened this issue Jan 29, 2024 · 2 comments · May be fixed by #5168
Open

Dropdown: panel closes while typing Japanese #5167

suntel-nagamine opened this issue Jan 29, 2024 · 2 comments · May be fixed by #5168
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone
3.53.0

Comments

@suntel-nagamine
Copy link

Describe the bug

When I type Japanese using the IME and press "Enter" when using the Filter, the panel closes, which is quite inconvenient.

I would like you to separate the process for the IME's confirm (Enter) and the normal Enter so that the panel does not close.

Dropdown_Filter

Reproducer

https://codesandbox.io/p/sandbox/exciting-kirch-8pt7hz

PrimeVue version

3.47.2

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

Chrome 121, Firefox 122

Steps to reproduce the behavior

  1. open the Panel
  2. Enter Japanese characters in the Filter field.
  3. press "Enter" to confirm the Japanese word.

Expected behavior

  1. open the panel
  2. Enter Japanese characters in the Filter field.
  3. press "Enter" to confirm the Japanese word.
  4. type the next Japanese word
  5. press "Enter" to confirm the Japanese word.
  6. select from the extracted contents
  7. Panel closes
@suntel-nagamine suntel-nagamine added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 29, 2024
@mertsincan
Copy link
Member

Hi,

Could you please try it with the latest PrimeVue version?

@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 29, 2024
@mertsincan mertsincan added this to the 3.50.0 milestone Jan 29, 2024
suntel-nagamine added a commit to suntel-nagamine/primevue that referenced this issue Jan 29, 2024
@suntel-nagamine
Fix primefaces#5167 - Dropdown: panel closes while typing Japanese
57e4562
@suntel-nagamine suntel-nagamine linked a pull request Jan 29, 2024 that will close this issue
Open
@suntel-nagamine
Copy link
Author

suntel-nagamine commented Jan 29, 2024 •
edited

Thanks for the reply.

I tried with the latest 3.47.2 and the panel closed.
I have tried to fix it and have sent you a pull request.

@tugcekucukoglu tugcekucukoglu modified the milestones: 3.50.0, 3.51.0 Mar 15, 2024
@tugcekucukoglu tugcekucukoglu modified the milestones: 3.51.0, 3.53.0 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Milestone
3.53.0
Development

Successfully merging a pull request may close this issue.

Fix #5167 - Dropdown: panel closes while typing Japanese suntel-nagamine/primevue
3 participants
@mertsincan @tugcekucukoglu @suntel-nagamine