Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.47.x - Improve the structure of some components to comply with standards #5071

Closed
10 tasks done
mertsincan opened this issue Jan 12, 2024 · 0 comments
Closed
10 tasks done
Assignees
Labels
Type: Breaking Change Issue contains a breaking change related to a specific component Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@mertsincan
Copy link
Member

mertsincan commented Jan 12, 2024

Affected Components;

  • Checkbox
  • RadioButton
  • TriStateCheckbox
  • InputSwitch
  • ToggleButton
  • Slider
  • MultiSelect (Checkbox)
  • DataTable (Checkbox and RadioButton)
  • TreeTable (Checkbox)
  • Tree (Checkbox)

Changes;

Checkbox

Removed

  • hiddenInputWrapper and hiddenInput from pt options
  • inputProps from props
  • click and input from emits
  • focused param from CheckboxState and CheckboxContext

Added

  • box to pt options

RadioButton

Removed

  • hiddenInputWrapper and hiddenInput from pt options
  • inputProps from props
  • click from emits
  • focused param from RadioButtonState

Added

  • box to pt options
  • context.checked and context.disabled to RadioButtonContext
  • binary, readonly and tabindex to props

TriStateCheckbox

Removed

  • hiddenInputWrapper, hiddenInput and checkbox from pt options
  • inputProps from props
  • click and keydown from emits
  • focused param from TriStateCheckboxState and TriStateCheckboxContext

Added

  • box and input to pt options
  • inputClass, inputStyle and readonly to props

InputSwitch

Removed

  • hiddenInputWrapper and hiddenInput from pt options
  • inputProps from props
  • click and input from emits
  • focused param from InputSwitchState

Added

  • input to pt options
  • tabindex and readonly to props
  • checked and disabled params from InputSwitchContext

ToggleButton

Removed

  • hiddenInputWrapper and hiddenInput from pt options
  • inputProps from props
  • click from emits
  • focused param from ToggleButtonState

Added

  • input and box to pt options
  • readonly to props
  • active and disabled params from InputSwitchContext

MultiSelect

Removed

  • headerCheckboxContainer, hiddenInputWrapper, headerCheckboxIcon, checkboxContainer, checkbox and checkboxIcon from pt options
  • focused param from MultiSelectState

Added

  • itemCheckbox to pt options

DataTable

Removed

  • headerCheckboxWrapper, hiddenHeaderInputWrapper, hiddenHeaderInput, headerCheckboxIcon, checkboxWrapper, hiddenInputWrapper, hiddenInput, checkbox, checkboxIcon, radiobuttonWrapper, hiddenInputWrapper, radiobutton and radiobuttonIcon from pt options

Added

  • rowCheckbox and rowRadioButton to pt options

TreeTable

Removed

  • checkboxContainer, checkbox and checkboxIcon from pt options

Added

  • nodeCheckbox to pt options
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: Breaking Change Issue contains a breaking change related to a specific component labels Jan 12, 2024
@mertsincan mertsincan added this to the 3.47.0 milestone Jan 12, 2024
@mertsincan mertsincan self-assigned this Jan 12, 2024
mertsincan added a commit that referenced this issue Jan 12, 2024
mertsincan added a commit that referenced this issue Jan 14, 2024
mertsincan added a commit that referenced this issue Jan 14, 2024
mertsincan added a commit that referenced this issue Jan 14, 2024
mertsincan added a commit that referenced this issue Jan 14, 2024
mertsincan added a commit that referenced this issue Jan 14, 2024
mertsincan added a commit that referenced this issue Jan 14, 2024
mertsincan added a commit that referenced this issue Jan 14, 2024
mertsincan added a commit that referenced this issue Jan 14, 2024
mertsincan added a commit that referenced this issue Jan 18, 2024
@mertsincan mertsincan pinned this issue Jan 28, 2024
@mertsincan mertsincan changed the title Improve the structure of some components to comply with standards On 3.47.0 - Improve the structure of some components to comply with standards Jan 28, 2024
@mertsincan mertsincan changed the title On 3.47.0 - Improve the structure of some components to comply with standards v3.47.0 - Improve the structure of some components to comply with standards Jan 28, 2024
@mertsincan mertsincan changed the title v3.47.0 - Improve the structure of some components to comply with standards v3.47.0+, Improve the structure of some components to comply with standards Jan 28, 2024
@mertsincan mertsincan changed the title v3.47.0+, Improve the structure of some components to comply with standards v3.47.x - Improve the structure of some components to comply with standards Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking Change Issue contains a breaking change related to a specific component Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

1 participant