Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox: Input field no longer hidden #5172

Closed
dahjson opened this issue Jan 29, 2024 · 3 comments
Closed

Checkbox: Input field no longer hidden #5172

dahjson opened this issue Jan 29, 2024 · 3 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@dahjson
Copy link

dahjson commented Jan 29, 2024

Describe the bug

The containing div <div class="p-hidden-accessible" v-bind="ptm('hiddenInputWrapper')" :data-p-hidden-accessible="true"> around the input field was removed, and the input field is no longer hidden for the checkbox.

99b1edd#diff-3f9994e923862cdf274c4681cec5f730bd4dc420e932b39359400c959e8479fa

Reproducer

99b1edd#diff-3f9994e923862cdf274c4681cec5f730bd4dc420e932b39359400c959e8479fa

PrimeVue version

3.47.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@dahjson dahjson added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 29, 2024
@dahjson dahjson changed the title Checkbox: Input Field No Longer Hidden Checkbox: Input field no longer hidden Jan 29, 2024
@rubjo
Copy link
Contributor

rubjo commented Jan 30, 2024

Seeing the same, this is unfortunate. @mertsincan Would you happen to know which version to revert to when seeing this?

Edit: resolved my specific issue. I had outdated custom theme CSS which I had to update, as some component classes now have new classes when they are active (eg. active inputswitches now have .p-highlight instead of .p-inputswitch-checked. :)

@mertsincan
Copy link
Member

Hi,

We made improvements to accessibility in the last release. This change was truly necessary. Now the checkbox and radiobutton components are in a better state. Please see our changes; #5071

Also, we'll update all layouts asap. For now, you can update layout's theme-base folder from https://github.com/primefaces/primevue-sass-theme/releases/tag/3.47.2

Best Regards,

@dahjson
Copy link
Author

dahjson commented Jan 30, 2024

Updating the theme fixed the issue. Thanks for the quick response on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

3 participants