Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Bump the version of prettier and related prettier libraries to support typescript 4.3 new syntax #135

Closed

Conversation

HoYinChung
Copy link

The current prettier it depends on its the prettier 2.0.2

The latest version of the prettier 2.3.1 has solved the problem and support typescript 4.3
prettier/prettier#10642

It would be good to have it support in the pretty-quick package instead of having it installed the prettier package again.

It will unblock the user who are trying to use pretty-quick with typescript 4.3

@HoYinChung
Copy link
Author

@azz will it be good if we update the prettier version to the latest to support more features ?

@jantimon
Copy link
Collaborator

The current prettier it depends on its the prettier 2.0.2

That's only for developing pretty-quick itself - this will have no effect on users of pretty-quick.

The current peer dependency is set to >= 2.0.0 which already allows to use the latest prettier version.

@HoYinChung
Copy link
Author

i do installed the prettier latest version to support that. Found it more easy for the ts 4.3 user to use the pretty quick with this update. But it might not be necessary since not everyone is switching to 4.3

@azz
Copy link
Member

azz commented Jun 11, 2021

This bumps the minimum version of prettier required to use this package. Not really understanding why we'd want to do that?

@HoYinChung
Copy link
Author

This bumps the minimum version of prettier required to use this package. Not really understanding why we'd want to do that?

make sense it bump the min requirement. its not really what we want to do. Closing it

@HoYinChung HoYinChung closed this Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants