Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Node.source.offset from postcss@8 #9502

Merged
merged 3 commits into from Nov 9, 2020
Merged

Use Node.source.offset from postcss@8 #9502

merged 3 commits into from Nov 9, 2020

Conversation

fisker
Copy link
Member

@fisker fisker commented Oct 26, 2020

  • Try to use node.source.offset first
  • Throw errors if startOffset can't calculated.
  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker marked this pull request as ready for review October 26, 2020 10:25
sosukesuzuki
sosukesuzuki reviewed Oct 28, 2020
View reviewed changes
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this conflicts with #9500, please wait for the release of 2.2. If not, looks good to me.

@fisker
Copy link
Member Author

fisker commented Oct 28, 2020

Yes, we need wait for #9482

@fisker fisker changed the base branch from master to next November 3, 2020 06:56
@fisker
Copy link
Member Author

fisker commented Nov 3, 2020

Changed base to next, we can merge after #9584

@fisker fisker merged commit 2f86c13 into prettier:next Nov 9, 2020
@fisker fisker deleted the postcss-source-offset branch November 9, 2020 09:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki left review comments

@thorn0 thorn0 thorn0 approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fisker @thorn0 @alexander-akait @sosukesuzuki