New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YAML: Fix printing doubles a blank line before a comment #9143
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
84f97df
Print hardline for endComments only when under mappingValue
sosukesuzuki a1d9395
Add changelog
sosukesuzuki 3b4b8f9
Fix from linter
sosukesuzuki 6c666fc
Update tests
sosukesuzuki 70b5a76
Use shouldPrintEndCommentsWithAlign
sosukesuzuki 1ea45d4
Add tests
sosukesuzuki 9562fe4
Add test
fisker 3fb93b0
Fix format
fisker 6d921b2
Update test
fisker c0ed2fe
Test map too
fisker ea4a29d
Update tests
fisker 1bd970f
`shouldPrintEndCommentsWithAlign` -> `shouldPrintEndComments`
fisker File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
#### Fix printing doubles a blank line before a comment (#9143 by @sosukesuzuki) | ||
|
||
<!-- prettier-ignore --> | ||
```yaml | ||
# Input | ||
- foo: 0 | ||
bar: 1 | ||
|
||
# baz: 2 | ||
- quux: 3 | ||
|
||
# Prettier stable | ||
- foo: 0 | ||
bar: 1 | ||
|
||
|
||
# baz: 2 | ||
- quux: 3 | ||
|
||
# Prettier master | ||
- foo: 0 | ||
bar: 1 | ||
|
||
# baz: 2 | ||
- quux: 3 | ||
|
||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
- foo: 0 | ||
bar: 1 | ||
|
||
# baz: 2 | ||
- quux: 3 | ||
|
||
- foo: 0 | ||
bar: 1 | ||
|
||
# baz: 2 | ||
|
||
# baz: 3 | ||
- quux: 3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
before: | ||
|
||
# before.comment | ||
after: | ||
# after.comment | ||
|
||
before-after: | ||
|
||
# before-after.comment | ||
|
||
none: | ||
# none.comment | ||
before(2 line): | ||
|
||
|
||
# before.comment | ||
after(2 line): | ||
# after.comment | ||
|
||
|
||
before-after(2 line): | ||
|
||
|
||
# before-after.comment | ||
|
||
|
||
none(2): | ||
# none.comment |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
- before | ||
|
||
# before.comment | ||
- after | ||
# after.comment | ||
|
||
- before-after | ||
|
||
# before-after.comment | ||
|
||
- none: | ||
# none.comment | ||
- before(2 line) | ||
|
||
|
||
# before.comment | ||
- after(2 line) | ||
# after.comment | ||
|
||
|
||
- before-after(2 line) | ||
|
||
|
||
# before-after.comment | ||
|
||
|
||
- none(2) | ||
# none.comment |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
- - a | ||
|
||
# - b | ||
|
||
# - c | ||
|
||
- e | ||
|
||
- - a | ||
|
||
# - b | ||
|
||
# - c |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is strange!!!
Prettier pr-9143
Playground link
Input:
Output:
Prettier pr-9143
Playground link
Input:
Output:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, seems attaching logic issue. I'll open an issue in the parser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue in
yaml-unist-parser
prettier/yaml-unist-parser#275