-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build(deps): Bump @typescript-eslint/typescript-estree from 3.10.1 to 4.0.1 #9119
Closed
dependabot
wants to merge
3
commits into
master
from
dependabot/npm_and_yarn/typescript-eslint/typescript-estree-4.0.1
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with typescript, but is it possible to have other types inside
ChainExpression?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering is this a mistake in parser?
ChainExpressionshould be the root ofoptional chaining.Shouldn't it be
TSNonNullExpression > ChainExpression?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bradzacher
What should this
c?.d!be? The estree sayshttps://github.com/estree/estree/blob/master/es2020.md#chainexpression
But in this case
TSNonNullExpressionis notChainElement.I'm not familiar with typescript, is thisc?.d!meandis non-null, and(c?.d)!meanc.dis non-null?If it's correct, shouldn'tTSNonNullExpressionbe theMemberExpression.property?Update: as I see on prettier playground,
(a?.b!).c(a?.b)!.care the same, so I think the AST should beTSNonNullExpression > ChainExpressionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mirrored babel's (v7.11.3) implementation here.
This is the same AST they produce. typescript-eslint/typescript-eslint#2380
input code:
`@babel/parser` @ `7.11.3`
{ "type": "Program", "start": 0, "end": 21, "loc": { "start": { "line": 1, "column": 0 }, "end": { "line": 2, "column": 10 } }, "sourceType": "module", "interpreter": null, "body": [ { "type": "ExpressionStatement", "start": 0, "end": 10, "loc": { "start": { "line": 1, "column": 0 }, "end": { "line": 1, "column": 10 } }, "expression": { "type": "MemberExpression", "start": 0, "end": 9, "loc": { "start": { "line": 1, "column": 0 }, "end": { "line": 1, "column": 9 } }, "object": { "type": "ChainExpression", "start": 1, "end": 6, "loc": { "start": { "line": 1, "column": 1 }, "end": { "line": 1, "column": 6 } }, "expression": { "type": "TSNonNullExpression", "start": 1, "end": 6, "loc": { "start": { "line": 1, "column": 1 }, "end": { "line": 1, "column": 6 } }, "expression": { "type": "MemberExpression", "start": 1, "end": 5, "loc": { "start": { "line": 1, "column": 1 }, "end": { "line": 1, "column": 5 } }, "object": { "type": "Identifier", "start": 1, "end": 2, "loc": { "start": { "line": 1, "column": 1 }, "end": { "line": 1, "column": 2 }, "identifierName": "a" }, "name": "a" }, "computed": false, "property": { "type": "Identifier", "start": 4, "end": 5, "loc": { "start": { "line": 1, "column": 4 }, "end": { "line": 1, "column": 5 }, "identifierName": "b" }, "name": "b" }, "optional": true } }, "extra": { "parenthesized": true, "parenStart": 0 } }, "computed": false, "property": { "type": "Identifier", "start": 8, "end": 9, "loc": { "start": { "line": 1, "column": 8 }, "end": { "line": 1, "column": 9 }, "identifierName": "c" }, "name": "c" }, "optional": false } }, { "type": "ExpressionStatement", "start": 11, "end": 21, "loc": { "start": { "line": 2, "column": 0 }, "end": { "line": 2, "column": 10 } }, "expression": { "type": "MemberExpression", "start": 11, "end": 20, "loc": { "start": { "line": 2, "column": 0 }, "end": { "line": 2, "column": 9 } }, "object": { "type": "TSNonNullExpression", "start": 11, "end": 18, "loc": { "start": { "line": 2, "column": 0 }, "end": { "line": 2, "column": 7 } }, "expression": { "type": "ChainExpression", "start": 12, "end": 16, "loc": { "start": { "line": 2, "column": 1 }, "end": { "line": 2, "column": 5 } }, "expression": { "type": "MemberExpression", "start": 12, "end": 16, "loc": { "start": { "line": 2, "column": 1 }, "end": { "line": 2, "column": 5 } }, "object": { "type": "Identifier", "start": 12, "end": 13, "loc": { "start": { "line": 2, "column": 1 }, "end": { "line": 2, "column": 2 }, "identifierName": "a" }, "name": "a" }, "computed": false, "property": { "type": "Identifier", "start": 15, "end": 16, "loc": { "start": { "line": 2, "column": 4 }, "end": { "line": 2, "column": 5 }, "identifierName": "b" }, "name": "b" }, "optional": true }, "extra": { "parenthesized": true, "parenStart": 11 } } }, "computed": false, "property": { "type": "Identifier", "start": 19, "end": 20, "loc": { "start": { "line": 2, "column": 8 }, "end": { "line": 2, "column": 9 }, "identifierName": "c" }, "name": "c" }, "optional": false } } ] }`@typescript-eslint/typescript-estree` @ `4.0.1`
{ "type": "Program", "body": [ { "type": "ExpressionStatement", "expression": { "type": "MemberExpression", "object": { "type": "ChainExpression", "expression": { "type": "TSNonNullExpression", "expression": { "type": "MemberExpression", "object": { "type": "Identifier", "name": "a", "range": [ 1, 2 ] }, "property": { "type": "Identifier", "name": "b", "range": [ 4, 5 ] }, "computed": false, "optional": true, "range": [ 1, 5 ] }, "range": [ 1, 6 ] }, "range": [ 1, 6 ] }, "property": { "type": "Identifier", "name": "c", "range": [ 8, 9 ] }, "computed": false, "optional": false, "range": [ 0, 9 ] }, "range": [ 0, 10 ] }, { "type": "ExpressionStatement", "expression": { "type": "MemberExpression", "object": { "type": "TSNonNullExpression", "expression": { "type": "ChainExpression", "expression": { "type": "MemberExpression", "object": { "type": "Identifier", "name": "a", "range": [ 12, 13 ] }, "property": { "type": "Identifier", "name": "b", "range": [ 15, 16 ] }, "computed": false, "optional": true, "range": [ 12, 16 ] }, "range": [ 12, 16 ] }, "range": [ 11, 18 ] }, "property": { "type": "Identifier", "name": "c", "range": [ 19, 20 ] }, "computed": false, "optional": false, "range": [ 11, 20 ] }, "range": [ 11, 21 ] } ], "sourceType": "script", "range": [ 0, 21 ] }There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the information, I'll take a deep look