Replace changelog versions in ./scripts/draft-blog-post.js #9058
Conversation
scripts/draft-blog-post.js
Outdated
|
|
||
| const changelogUnreleasedDir = path.join(__dirname, "../changelog_unreleased"); | ||
| const blogDir = path.join(__dirname, "../website/blog"); | ||
| const introFile = path.join(changelogUnreleasedDir, "blog-post-intro.md"); | ||
| const version = require("../package.json").version.replace(/-.+/, ""); | ||
| const previousVersion = execSync("git describe --tags --abbrev=0") |
There was a problem hiding this comment.
how about require('prettier/package.json').version
| @@ -80,22 +82,24 @@ rimraf.sync(postGlob); | |||
|
|
|||
| fs.writeFileSync( | |||
There was a problem hiding this comment.
Should we run prettier.format on this file?
There was a problem hiding this comment.
This file is created when repo linting with stable, and merge when master already released and updated, so there is a chance this file will fail on lint?
There was a problem hiding this comment.
There may be a chance. But we use this script when before release. So I'm not sure if the problem is fixed with using prettier.format on this script.
There was a problem hiding this comment.
If we use stable prettier format it, it will fail after merge.
If we use master prettier format it, it will fail when sending PR.
😄
There was a problem hiding this comment.
Let's keep as it is, for now.
#8932 (comment)
✨Try the playground for this PR✨