Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript: Fix broken format for ...infer T #9044

Merged
merged 1 commit into from Aug 25, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions changelog_unreleased/typescript/pr-9044.md
@@ -0,0 +1,13 @@
#### Fix broken format for `...infer T` ([#9044](https://github.com/prettier/prettier/pull/9044) by [@fisker](https://github.com/fisker))

<!-- prettier-ignore -->
```typescript
// Input
type Tail<T extends any[]> = T extends [infer U, ...infer R] ? R : never;

// Prettier stable
type Tail<T extends any[]> = T extends [infer U, ...(infer R)] ? R : never;

// Prettier master
type Tail<T extends any[]> = T extends [infer U, ...infer R] ? R : never;
```
6 changes: 5 additions & 1 deletion src/language-js/needs-parens.js
Expand Up @@ -417,8 +417,12 @@ function needsParens(path, options) {
return true;
}
// fallthrough
case "TSTypeOperator":
case "TSInferType":
if (node.type === "TSInferType" && parent.type === "TSRestType") {
return false;
}
// fallthrough
case "TSTypeOperator":
return (
parent.type === "TSArrayType" ||
parent.type === "TSOptionalType" ||
Expand Down
25 changes: 25 additions & 0 deletions tests/typescript/rest-type/__snapshots__/jsfmt.spec.js.snap
Expand Up @@ -14,6 +14,31 @@ type TupleWithRest = [number, ...(1 extends 2 ? string[] : number[])];
================================================================================
`;

exports[`infer-type.ts format 1`] = `
====================================options=====================================
parsers: ["typescript"]
printWidth: 80
| printWidth
=====================================input======================================
type Tail<T extends any[]> = T extends [infer U, ...infer R] ? R : never;

type ReduceNextElement<
T extends readonly unknown[]
> = T extends readonly [infer V, ...infer R] ? [V, R] : never

=====================================output=====================================
type Tail<T extends any[]> = T extends [infer U, ...infer R] ? R : never;

type ReduceNextElement<T extends readonly unknown[]> = T extends readonly [
infer V,
...infer R
]
? [V, R]
: never;

================================================================================
`;

exports[`simple.ts format 1`] = `
====================================options=====================================
parsers: ["typescript"]
Expand Down
5 changes: 5 additions & 0 deletions tests/typescript/rest-type/infer-type.ts
@@ -0,0 +1,5 @@
type Tail<T extends any[]> = T extends [infer U, ...infer R] ? R : never;

type ReduceNextElement<
T extends readonly unknown[]
> = T extends readonly [infer V, ...infer R] ? [V, R] : never