Revert "[TypeScript] format TSAsExpression with same logic as BinaryExpression" #7958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorn0
force-pushed
the
revert-7869-tsasexp
branch
from
4fb317f
to
bc8d6a3
Compare
thorn0
force-pushed
the
revert-7869-tsasexp
branch
from
bc8d6a3
to
da6a51a
Compare
|
@thorn0 I'm sorry that the PR I created caused a regression. Thanks for the revert. I was surprised that 2.0.3 was released suddenly. Could you tell me about the release cycle? Even if it was a patch version release, we should have used other source code to check for regressions. |
|
@sosukesuzuki The new major version of the VS Code extension was broken because of #7949 That's why I made this patch release. But I should've tested it more thoroughly, indeed. :( |
alexander-akait
approved these changes
Apr 6, 2020
|
Hopefully, we're done with 2.0 regressions and there will be no more 2.0.x releases. |
|
Thanks for the quick response on this one @thorn0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7869
fixes #7956
fixes #7957
reopens #6443