Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup work on setup github actions #7431

Merged
merged 37 commits into from Mar 23, 2020
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
412bb10
Followup work on setup github actions
fisker Jan 25, 2020
d49207d
Coverage report & split `prod_lint`
fisker Jan 25, 2020
254278e
Add env
fisker Jan 25, 2020
2735e45
Remove coverage report on azure pipelines
fisker Jan 25, 2020
ad855a1
Remove build step on lint
fisker Jan 25, 2020
273381d
remove coverage report on prod_test
fisker Jan 25, 2020
d55836f
Use `ci-info` instead of `is-ci`
fisker Jan 25, 2020
3ff3798
Always enable `ENABLE_TEST_RESULTS` and `AST_COMPARE` on CI
fisker Jan 25, 2020
689e14e
Merge branch 'ci-env' into adjust-github-actions
fisker Jan 25, 2020
d38e456
Standalone test and remove some env
fisker Jan 25, 2020
19d8967
coverage report
fisker Jan 25, 2020
6f55df1
reduce matrix
fisker Jan 25, 2020
7df8ef8
Merge branch 'next' into adjust-github-actions
fisker Feb 14, 2020
9275fc2
standalone test
fisker Feb 14, 2020
f1133ad
Merge branch 'next' into adjust-github-actions
fisker Feb 14, 2020
a63f1a5
Merge branch 'next' into adjust-github-actions
fisker Mar 17, 2020
ce57952
`ci-info`
fisker Mar 17, 2020
5edd2de
Remove token
fisker Mar 17, 2020
404c81c
Disable `coverage` on azure pipelines
fisker Mar 17, 2020
7815cc5
use master version of codecov-action
fisker Mar 17, 2020
838e0f7
Link to master status
fisker Mar 17, 2020
767ffb6
fix prod lint
fisker Mar 17, 2020
869bf20
Use boolean env
fisker Mar 17, 2020
57ecc9a
Remove locv report
fisker Mar 17, 2020
3dcbf7d
Merge branch 'next' into adjust-github-actions
fisker Mar 18, 2020
7e61875
Try lcov report
fisker Mar 18, 2020
53f55fa
pin `codecov-action` version, enable `verbose`
fisker Mar 18, 2020
293c0c7
Merge branch 'next' into adjust-github-actions
fisker Mar 19, 2020
f2fb408
azure coverage
fisker Mar 19, 2020
e13fc68
Name
fisker Mar 19, 2020
a2acc7e
Trigger CI
fisker Mar 19, 2020
777253f
Use `basename`
fisker Mar 20, 2020
8e7f033
Trigger CI
fisker Mar 20, 2020
ac38ef0
Try `runInBand`
fisker Mar 21, 2020
173a068
Merge branch 'adjust-github-actions' of 13.114.40.48:fisker/prettier …
fisker Mar 21, 2020
a6e476a
try `maxWorkers`
fisker Mar 21, 2020
c2bf918
Merge branch 'master' into adjust-github-actions
thorn0 Mar 21, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion .azure-pipelines/jobs/dev-test.yml
Expand Up @@ -4,4 +4,3 @@ steps:
- script: yarn test
displayName: "Run tests"
- template: ../steps/publish-test-results.yml
- template: ../steps/publish-code-coverage.yml
1 change: 0 additions & 1 deletion .azure-pipelines/jobs/prod-test.yml
Expand Up @@ -5,4 +5,3 @@ steps:
- script: yarn test:dist
displayName: "Run tests on dist"
- template: ../steps/publish-test-results.yml
- template: ../steps/publish-code-coverage.yml
11 changes: 0 additions & 11 deletions .azure-pipelines/steps/publish-code-coverage.yml

This file was deleted.

20 changes: 15 additions & 5 deletions .github/workflows/dev-test.yml
@@ -1,6 +1,6 @@
name: Dev_Test

on: [pull_request]
on: [push, pull_request]

jobs:
dev_test:
Expand All @@ -15,8 +15,11 @@ jobs:
- "13"
- "12"
- "10"

name: Dev test on node ${{ matrix.node }} and ${{ matrix.os }}
env:
AST_COMPARE: true
ENABLE_TEST_RESULTS: true
ENABLE_CODE_COVERAGE: true
name: Node.js ${{ matrix.node }} on ${{ matrix.os }}
runs-on: ${{ matrix.os }}
steps:
- name: Checkout
Expand All @@ -27,10 +30,17 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.NODE }}
node-version: ${{ matrix.node }}

- name: Install Dependencies
run: yarn install --frozen-lockfile

- name: Run Test
- name: Run Tests
run: yarn test

- name: Upload Coverage To Codecov
uses: codecov/codecov-action@v1
with:
token: ${{ secrets.CODECOV_TOKEN }}
file: ./coverage/cobertura-coverage.xml
fail_ci_if_error: true
15 changes: 9 additions & 6 deletions .github/workflows/lint.yml
@@ -1,6 +1,6 @@
name: Lint

on: [pull_request]
on: [push, pull_request]

jobs:
lint:
Expand All @@ -20,21 +20,24 @@ jobs:
- name: Install Dependencies
run: yarn install --frozen-lockfile

- name: Check dependencies
- name: Check Dependencies
run: yarn check-deps

- name: Check JSDoc types
- name: Check JSDoc Types
run: yarn check-types

- name: Lint code
- name: Lint Code
run: yarn lint

- name: Lint docs
- name: Lint Docs
run: yarn lint-docs

- name: Spellcheck
run: yarn spellcheck

- name: Check file changes
- name: Lint Changelog
run: yarn lint-changelog

- name: Check File Changes
run: yarn && echo "Listing changed files:" && git diff --name-only --exit-code && echo "No files changed during lint."

37 changes: 33 additions & 4 deletions .github/workflows/prod-test.yml
@@ -1,6 +1,6 @@
name: Prod_Test

on: [pull_request]
on: [push, pull_request]

jobs:
build:
Expand Down Expand Up @@ -29,6 +29,33 @@ jobs:
name: dist
path: dist

prod_lint:
name: Lint
runs-on: ubuntu-latest
needs: [build]
steps:
- name: Checkout
uses: actions/checkout@v2
with:
fetch-depth: 1

- name: Setup Node.js
uses: actions/setup-node@v1
with:
node-version: "12"

- name: Install Dependencies
run: yarn install --frozen-lockfile

- name: Download Artifact
uses: actions/download-artifact@v1
with:
name: dist
path: dist

- name: Lint Code
run: yarn test:dist

prod_test:
strategy:
fail-fast: false
Expand All @@ -41,8 +68,10 @@ jobs:
- "13"
- "12"
- "10"

name: Prod test on node ${{ matrix.node }} and ${{ matrix.os }}
env:
AST_COMPARE: true
ENABLE_TEST_RESULTS: true
name: Node.js ${{ matrix.node }} on ${{ matrix.os }}
runs-on: ${{ matrix.os }}
needs: [build]
steps:
Expand All @@ -65,5 +94,5 @@ jobs:
name: dist
path: dist

- name: Run Test
- name: Run Tests
run: yarn test:dist