Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check file changes on CI #7342

Merged
merged 2 commits into from Jan 16, 2020
Merged

Check file changes on CI #7342

merged 2 commits into from Jan 16, 2020

Conversation

fisker
Copy link
Member

@fisker fisker commented Jan 15, 2020 •
edited

Current next branch should be red, after #7341 merge, should turn green.

Fail log: https://dev.azure.com/prettier/prettier/_build/results?buildId=4196&view=logs&j=8a711e17-ead8-5584-625e-ca1b4bc9de05&t=d5c21e83-f1d5-5f2b-543a-0c9d2c919ce9&l=25

Success log: https://dev.azure.com/prettier/prettier/_build/results?buildId=4256&view=logs&j=8a711e17-ead8-5584-625e-ca1b4bc9de05&t=d5c21e83-f1d5-5f2b-543a-0c9d2c919ce9&l=19

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker force-pushed the lock-check-on-ci branch 2 times, most recently from 5ec4d56 to da22c4c Compare January 15, 2020 08:25
@fisker fisker changed the title Run lock check on CI Check file changes on CI Jan 15, 2020
@fisker fisker marked this pull request as ready for review January 15, 2020 08:26
@fisker fisker force-pushed the lock-check-on-ci branch 2 times, most recently from 0d7bb23 to e70ecb1 Compare January 15, 2020 08:50
@fisker
Copy link
Member Author

fisker commented Jan 15, 2020 •
edited

@thorn0 @evilebottnawi Can we add this test? As I know Last time same problem #6853 (comment)

@alexander-akait alexander-akait merged commit 5ff6c37 into prettier:next Jan 16, 2020
@fisker fisker deleted the lock-check-on-ci branch January 16, 2020 10:37
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Apr 15, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thorn0 thorn0 thorn0 approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fisker @thorn0 @alexander-akait