test with duplicated class name #6815
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on: tests_integration/__tests__/syntax-error.js Co-authored-by: Georgii Dolzhykov <thorn.mailbox@gmail.com>
|
closing in favor of #6816 |
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@thorn0 pointed out in #6469 (comment) that the behavior in case of
class A {} class A {}had changed since 1.18.2, due to an update of@babel/parser.Here is a test that should confirm the current behavior and hopefully ensure that it does break in the future. The test description and snapshot are based on the new behavior, but it should be straightforward (trivial) to change it for the old behavior if needed.
I did also confirm that rollback to @babel/parser@7.2.0 would give us the old behavior.
I’ve added tests to confirm my change works.(If changing the API or CLI) I’ve documented the changes I’ve made (in thedocs/directory)(If the change is user-facing) I’ve added my changes to theCHANGELOG.unreleased.mdfile following the template.✨Try the playground for this PR✨