Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post, changelog and docs for 1.19 #6787

Merged
merged 22 commits into from Nov 9, 2019
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Expand Up @@ -5,7 +5,7 @@

- [ ] I’ve added tests to confirm my change works.
- [ ] (If changing the API or CLI) I’ve documented the changes I’ve made (in the `docs/` directory)
- [ ] (If the change is user-facing) I’ve added my changes to the `CHANGELOG.unreleased.md` file following the template.
- [ ] (If the change is user-facing) I’ve added my changes to `changelog_unreleased/*/pr-XXXX.md` file following `changelog_unreleased/TEMPLATE.md`.
- [ ] I’ve read the [contributing guidelines](https://github.com/prettier/prettier/blob/master/CONTRIBUTING.md).

**✨[Try the playground for this PR](https://prettier.io/playground-redirect)✨**
39 changes: 39 additions & 0 deletions changelog_unreleased/TEMPLATE.md
@@ -0,0 +1,39 @@
<!--

1. Choose a folder based on which language your PR is for.

- For JavaScript, choose `javascript/` etc.
- For TypeScript specific syntax, choose `typescript/`.
- If your PR applies to multiple languages, such as TypeScript/Flow, choose one folder and mention which languages it applies to.

2. In your chosen folder, create a file with your PR number: `pr-XXXX.md`. For example: `typescript/pr-6728.md`.

3. Copy the content below and paste it in your new file.

4. Fill in a title, the PR number and your user name.

5. Optionally write a description. Many times it’s enough with just sample code.

6. Change ```jsx to your language. For example, ```yaml.

7. Change the `// Input` and `// Output` comments to the comment syntax of your language. For example, `# Input`.

8. Choose some nice input example code. Paste it along with the output before and after your PR.

-->

#### Title ([#XXXX](https://github.com/prettier/prettier/pull/XXXX) by [@user](https://github.com/user))
lydell marked this conversation as resolved.
Show resolved Hide resolved

Optional description if it makes sense.

<!-- prettier-ignore -->
```jsx
// Input
(foo ?? baz) || baz;

// Prettier stable
foo ?? baz || baz;

// Prettier master
(foo ?? baz) || baz;
```
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
1 change: 1 addition & 0 deletions cspell.json
Expand Up @@ -337,6 +337,7 @@
"superset",
"supertypes",
"swac",
"systemjs",
"tdeekens",
"templating",
"tempy",
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -130,6 +130,6 @@
"build": "node --max-old-space-size=3072 ./scripts/build/build.js",
"build-docs": "node ./scripts/build-docs.js",
"check-deps": "node ./scripts/check-deps.js",
"spellcheck": "npx -p cspell@4.0.31 cspell {bin,scripts,src}/**/*.js {docs,website/blog}/**/*.md CHANGELOG.unreleased.md"
"spellcheck": "npx -p cspell@4.0.31 cspell {bin,scripts,src}/**/*.js {docs,website/blog,changelog_unreleased}/**/*.md"
}
}
2 changes: 1 addition & 1 deletion scripts/release/steps/update-changelog.js
Expand Up @@ -57,7 +57,7 @@ module.exports = async function({ version, previousVersion }) {
dedent(chalk`
{yellow.bold A manual step is necessary.}

You can copy the entries from {bold CHANGELOG.unreleased.md} to {bold CHANGELOG.md}
You can copy the entries from {bold changelog_unreleased/*/pr-*.md} to {bold CHANGELOG.md}
and update it accordingly.

You don't need to commit the file, the script will take care of that.
Expand Down