Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added 'orderedListMarker' option #6625

Conversation

alexandrtovmach
Copy link

Hey there!

I tried to implement new option for markdown files called orderedListMarker. I faced with a problem that I can't force the type of list marks globally and auto detect sometimes make unexpected stuff:

Example playground

Here is one old related issue: #3463

New option give an ability to set specific type of number mark:

--ordered-list-marker <order|one|auto>

Let's discuss this feature! If we agreed with that I can add docs and tests.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

@kachkaev
Copy link
Member

kachkaev commented Oct 8, 2019

Not sure these options are needed. See https://prettier.io/docs/en/option-philosophy.html and #40

@alexandrtovmach
Copy link
Author

alexandrtovmach commented Oct 8, 2019

@kachkaev Okay, sounds reasonable, but this option is requested in provided issue #3463. Part of requested features are already implemented, but this option still not exist and haven't any analogues.

@thorn0 thorn0 added the type:option request Issues requesting a new option. We generally don’t accept these unless there is technical necessity. label Oct 30, 2019
@JounQin
Copy link
Member

JounQin commented Nov 17, 2019

@alexandrtovmach

You can try eslint-mdx and remark-preset-prettier.

Don't think we should add an option for it.

@alexander-akait
Copy link
Member

Thanks for the PR, we don't need this option you can use remark-link or other packages for enforce list markers for your code base

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 16, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:option request Issues requesting a new option. We generally don’t accept these unless there is technical necessity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants