fix: handle long globs #16233
Open
fix: handle long globs #16233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prettier wraps lstat to look for cases where a file does not exist... When it does not exist, it will try treating the argument as a glob. For very long globs, the system will return ENAMETOOLONG instead of ENOENT. This is still a case where the file does not exist and where a glob could exist. Instead of letting that error bubble up as an uncaught exception, swallow it in the same manner as ENOENT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prettier wraps
lstatto look for cases where a file does not exist... When it does not exist, it will try treating the argument as a glob.For very long globs, the system will return
ENAMETOOLONGinstead ofENOENT. This is still a case where the file does not exist and where a glob could exist.Instead of letting that error bubble up as an uncaught exception, swallow it in the same manner as
ENOENT.Fixes #16115.
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨