Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown: format correctly table when columns are missing #16231

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

yanapeycheva
Copy link

@yanapeycheva yanapeycheva commented Apr 23, 2024

Description

Resolves #15970.

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@kachkaev
Copy link
Member

@fisker WDYT? Seems like this PR can resolve the issue you’ve opened: #15970

@fisker
Copy link
Sponsor Member

fisker commented Apr 29, 2024

The output looks good.

The CI seems not running.

@fisker fisker closed this Apr 29, 2024
@fisker fisker reopened this Apr 29, 2024
@yanapeycheva
Copy link
Author

Hello. I forgot to run yarn fix before the pull request. Is it possible that this causes the pipeline to fail? I just pushed the commit with the formatted file.

@kachkaev
Copy link
Member

@yanapeycheva CI is still failing. Can you have another look please? We’re close 🤞

@kachkaev
Copy link
Member

Looks like you need to update a couple of test snapshots. Try yarn test -u locally to update them. You can find a few more details in CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print empty columns in markdown table
3 participants