feat: add support for package.yaml config
#16157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbayley
force-pushed
the
package-yaml
branch
from
034285d
to
d00c303
Compare
|
I did not know this pnpm feature. Is there any official documentation? Or are there other tools besides pnpm that support this format? |
@sosukesuzuki See pnpm/pnpm.io#487.
Support has already been added to lint-staged, cosmiconfig, and commitlint, so far… |
danielbayley
force-pushed
the
package-yaml
branch
from
d00c303
to
bb96162
Compare
|
So, we have to support |
@fisker Not as far as I’m concerned. I don’t personally see the point of JSON with comments, when YAML is available… Maybe ideally as an option it should, but that would be for a separate PR anyway… |
Sounds good. |
fisker
reviewed
Apr 4, 2024
fisker
reviewed
Apr 10, 2024
danielbayley
force-pushed
the
package-yaml
branch
2 times, most recently
from
138515f
to
031fa8c
Compare
fisker
requested changes
Apr 11, 2024
danielbayley
force-pushed
the
package-yaml
branch
from
031fa8c
to
225bd4a
Compare
danielbayley
force-pushed
the
package-yaml
branch
from
225bd4a
to
a1f121e
Compare
fisker
approved these changes
Apr 11, 2024
fisker
requested changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable support for reading
prettierconfiguration directly frompackage.yaml.Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨