Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add newline between markdown footnote definitions #16063

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+77 −2
Open

Add newline between markdown footnote definitions #16063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c7c31f
Add newline between markdown footnoteDefinitions
Atema Feb 8, 2024
78f8360
Add changelog (markdown: whitespace between footnotes)
Atema Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions changelog_unreleased/markdown/16063.md
View file
Open in desktop
@@ -0,0 +1,18 @@
#### Add newline between markdown footnote definitions (#16063 by @Atema)

<!-- prettier-ignore -->
```md
<!-- Input -->
[^a]: Footnote A

[^b]: Footnote B

<!-- Prettier stable -->
[^a]: Footnote A
[^b]: Footnote B

<!-- Prettier main -->
[^a]: Footnote A

[^b]: Footnote B
```
2 changes: 0 additions & 2 deletions src/language-markdown/printer-markdown.js
View file
Open in desktop
Expand Up @@ -44,7 +44,6 @@ import {
const SIBLING_NODE_TYPES = new Set([
"listItem",
"definition",
"footnoteDefinition",
]);

function genericPrint(path, options, print) {
Expand Down Expand Up @@ -405,7 +404,6 @@ function genericPrint(path, options, print) {
isFirst ? group([softline, print()]) : print(),
}),
),
path.next?.type === "footnoteDefinition" ? softline : "",
]),
];
}
Expand Down
59 changes: 59 additions & 0 deletions tests/format/markdown/footnoteDefinition/__snapshots__/format.test.js.snap
View file
Open in desktop
Expand Up @@ -37,6 +37,7 @@ proseWrap: "never"

=====================================output=====================================
[^hello]: this is a long long long long long long long long long long long long long paragraph.

[^world]: this is a long long long long long long long long long long long long long paragraph. this is a long long long long long long long long long long long long long paragraph.

================================================================================
Expand All @@ -55,6 +56,7 @@ proseWrap: "preserve"

=====================================output=====================================
[^hello]: this is a long long long long long long long long long long long long long paragraph.

[^world]:
this is a long long long long long long long long long long long long long paragraph.
this is a long long long long long long long long long long long long long paragraph.
Expand All @@ -75,6 +77,7 @@ tabWidth: 3

=====================================output=====================================
[^hello]: this is a long long long long long long long long long long long long long paragraph.

[^world]:
this is a long long long long long long long long long long long long long paragraph.
this is a long long long long long long long long long long long long long paragraph.
Expand Down Expand Up @@ -352,31 +355,45 @@ proseWrap: "always"

=====================================output=====================================
[^a]: a

[^a]: a

[^a]: a

[^a]: > 123

[^a]: a

[^a]: > 123

[^a]: a

[^a]: a

[^a]: a

---

[^a]: a

[^a]: a

[^a]: a

[^a]:
> 123\\
> 456

[^a]: a

[^a]:
> 123\\
> 456

[^a]: a

[^a]: a

[^a]: a

================================================================================
Expand Down Expand Up @@ -415,31 +432,45 @@ proseWrap: "never"

=====================================output=====================================
[^a]: a

[^a]: a

[^a]: a

[^a]: > 123

[^a]: a

[^a]: > 123

[^a]: a

[^a]: a

[^a]: a

---

[^a]: a

[^a]: a

[^a]: a

[^a]:
> 123\\
> 456

[^a]: a

[^a]:
> 123\\
> 456

[^a]: a

[^a]: a

[^a]: a

================================================================================
Expand Down Expand Up @@ -478,31 +509,45 @@ proseWrap: "preserve"

=====================================output=====================================
[^a]: a

[^a]: a

[^a]: a

[^a]: > 123

[^a]: a

[^a]: > 123

[^a]: a

[^a]: a

[^a]: a

---

[^a]: a

[^a]: a

[^a]: a

[^a]:
> 123\\
> 456

[^a]: a

[^a]:
> 123\\
> 456

[^a]: a

[^a]: a

[^a]: a

================================================================================
Expand Down Expand Up @@ -541,31 +586,45 @@ tabWidth: 3

=====================================output=====================================
[^a]: a

[^a]: a

[^a]: a

[^a]: > 123

[^a]: a

[^a]: > 123

[^a]: a

[^a]: a

[^a]: a

---

[^a]: a

[^a]: a

[^a]: a

[^a]:
> 123\\
> 456

[^a]: a

[^a]:
> 123\\
> 456

[^a]: a

[^a]: a

[^a]: a

================================================================================
Expand Down