FIX: Correctly identify non-ascii JS variables in .vue files

[FilipRazek]

Description

Fix issue #13647 by using the correct regex for js variables

Checklist

• I’ve added tests to confirm my change works.
• (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
• (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
• I’ve read the contributing guidelines.

✨Try the playground for this PR✨

[fisker]

Do you have a reference for the updated pattern?

[FilipRazek]

From this SO thread (also mentioned in the constants.js file). However, the pattern is quite long - and probably not very maintainable, but I don't have enough experience with parsing to know what would be sufficient.

[FilipRazek]

The tests pass with a much simpler regex - [^\s;,]+, matching any character that is not whitespace and not a semicolon/colon.

[fisker]

Thanks for working on this, but I don't think we can simply change the regexp, we need to implement logic from https://github.com/vuejs/core/blob/f1068fc60ca511f68ff0aaedcc18b39124791d29/packages/compiler-core/src/transforms/vModel.ts and https://github.com/vuejs/core/blob/f1068fc60ca511f68ff0aaedcc18b39124791d29/packages/compiler-core/src/transforms/vOn.ts

[FilipRazek]

Alright, thanks for your comment! The logic seems quite complex and I'm not sure I'm able to understand everything. However, from what I've seen, the vModel calls a isSimpleIdentifier function, defined as such:

const nonIdentifierRE = /^\d|[^\$\w]/
export const isSimpleIdentifier = (name: string): boolean =>
  !nonIdentifierRE.test(name)

If there is more logic to implement, could you please tell me where to look?
Thanks!