Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent splitting of textarea's closing tag #15967

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

t-mangoe
Copy link
Contributor

Description

This PR fixes the issue #15432

Fix #15432

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@drewble
Copy link

drewble commented Mar 1, 2024

Can this fix be merged? Without it, formatting rules are inconsistently applied across HTML elements and the post-Prettier file looks broken.

@fisker
Copy link
Member

fisker commented Apr 4, 2024

Sorry, this will break html, we can't accept it.

<textarea id="a">a</textarea
>

<textarea id="b">a
</textarea>

<script>
  alert(a.value === b.value);
</script>

@jacobtylerwalls
Copy link

The underlying issue also affects the <span> tag, see playground

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing tag is split for long tag names and long lines.
4 participants