Fix comment duplication for experimental ternaries #15965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
reviewed
Jan 23, 2024
| }); | ||
| if (danglingComments) { | ||
| consequentComments.push(danglingComments, hardline); | ||
| } |
There was a problem hiding this comment.
I took some time to find the root cause, I think the problem here is we are printing the dangling comments in the consequent and the consequent will also print them.
Do you think we can check node type of consequent instead?
Something like:
const nodesShouldPrintDanglingComments = node =>
node.type === 'ArrayExpression' ||
node.type === 'ObjectExpression'
if (!nodesShouldPrintDanglingComments (node)) {
...
}
There was a problem hiding this comment.
This sounds plausible to me fwiw
rattrayalex
reviewed
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15875
Checklist
changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨