Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leading comments in mapped types with readonly (Cherry-pick #13427) #14310

Merged
merged 1 commit into from Feb 8, 2023
Merged

Fix leading comments in mapped types with readonly (Cherry-pick #13427) #14310

merged 1 commit into from Feb 8, 2023

Conversation

fisker
Copy link
Sponsor Member

@fisker fisker commented Feb 7, 2023

Description

As requested #13427 (comment)

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker marked this pull request as ready for review February 7, 2023 07:18
sosukesuzuki
sosukesuzuki approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@fisker fisker merged commit 6bb24b2 into prettier:main Feb 8, 2023
@fisker fisker deleted the backport-13427 branch February 8, 2023 01:41
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Jan 4, 2024
@fisker @medikoo
Fix leading comments in mapped types with readonly (Cherry-pick pre…
cf005ae 
…ttier#13427) (prettier#14310)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisker @sosukesuzuki