Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve keyword class property print #13997

Merged
merged 2 commits into from Dec 19, 2022
Merged

Improve keyword class property print #13997

merged 2 commits into from Dec 19, 2022

Conversation

fisker
Copy link
Sponsor Member

@fisker fisker commented Dec 15, 2022 •
edited

Description

#13919 (comment)

There are still problems in this function. The nextNode should also check type Identifier and string literal can also cause problems.

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker marked this pull request as ready for review December 15, 2022 09:00
@fisker fisker merged commit 985b895 into prettier:main Dec 19, 2022
@fisker fisker deleted the class-member branch December 19, 2022 05:20
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Jan 4, 2024
@fisker @medikoo
Improve keyword class property print (prettier#13997)
1a3c37f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisker @sosukesuzuki