Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support decorator auto accessors syntax #13919

Merged
merged 12 commits into from Dec 5, 2022
Merged

Support decorator auto accessors syntax #13919

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4555d4b
Install new ts-estree
sosukesuzuki Nov 30, 2022
7aa403f
Print auto accessor properties
sosukesuzuki Nov 30, 2022
ba35f42
Support edge cases
sosukesuzuki Nov 30, 2022
c6723fc
Misc tests
sosukesuzuki Nov 30, 2022
84fde47
Add tests for auto accessor with type annotations
sosukesuzuki Nov 30, 2022
a48cf7f
Add changelog
sosukesuzuki Nov 30, 2022
34770f2
Update changelog_unreleased/typescript/13919.md
sosukesuzuki Nov 30, 2022
929c2dd
Update changelog_unreleased/typescript/13919.md
sosukesuzuki Nov 30, 2022
c641b96
Print semicolon for accessor and add tests
sosukesuzuki Nov 30, 2022
604fc53
Add TODO comment
sosukesuzuki Dec 5, 2022
9055783
Add to properties list
sosukesuzuki Dec 5, 2022
45247b5
Address review
sosukesuzuki Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/language-js/print/statement.js
View file
Open in desktop
Expand Up @@ -177,7 +177,10 @@ const isClassProperty = ({ type }) =>
function shouldPrintSemicolonAfterClassProperty(node, nextNode) {
const name = node.key && node.key.name;
Copy link
Sponsor Member

@fisker fisker Dec 5, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are here. Let's remove this chaining, I don't think the key can be nullish here.

Suggested change
const name = node.key && node.key.name;
const { name } = node.key;

if (
(name === "static" || name === "get" || name === "set") &&
(name === "static" ||
fisker marked this conversation as resolved.
Show resolved Hide resolved
name === "get" ||
name === "set" ||
name === "accessor") &&
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a TODO comment about microsoft/TypeScript#51707

!node.value &&
!node.typeAnnotation
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

printClassProperty also prints ? or ! here

prettier/src/language-js/print/class.js

Line 229 in aa34209

printOptionalToken(path),
, not sure if we can omit semi here if those tokens exists, but we can investigate in feature.

We should also test private fields, since we use .key.name directly without check type.

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not checking computed either...

) {
Expand Down