New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @typescript-eslint/typescript-estree
to support satisfies
#13872
Conversation
I think we should release 2.8 after this PR is merged without waiting typescript-estree supports auto accessors because most users want to update to TypeScript 4.9 for the |
@@ -1,10 +1,8 @@ | |||
#### Support TypeScript 4.9 (#13764, #13783 by @sosukesuzuki) | |||
#### Support TypeScript 4.9 (#13764, #13783, #13872 by @sosukesuzuki) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this header instead?
#### Support TypeScript 4.9 (#13764, #13783, #13872 by @sosukesuzuki) | |
#### Support TypeScript 4.9 `satisfies` operator (#13764, #13783, #13872 by @sosukesuzuki) |
#### Support TypeScript 4.9 (#13764, #13783, #13872 by @sosukesuzuki) | |
#### Support TypeScript 4.9 [`satisfies`](https://devblogs.microsoft.com/typescript/announcing-typescript-4-9/#satisfies) operator (#13764, #13783, #13872 by @sosukesuzuki) |
Otherwise we start with an overpromise. Instead of adding a header for Auto-Accessors in Classes
we can say something like:
[Auto-Accessors in Classes](https://devblogs.microsoft.com/typescript/announcing-typescript-4-9/#auto-accessors-in-classes) will be supported in an upcoming 2.8 patch release. We have de-scoped them for now to ship `satisfies` operator sooner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it already supported by babel-ts
parser? User can switch to use it temporarily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@babel/parser
can parse auto accessors. But it cannot be used with type annotations to we need to wait babel/babel#15209
…rettier#13872) * Update to `5.43.1-alpha.22` * Update snapshots for satisfies * Update changelog * Remove `@ts-expect-error` comment * Yarn dedupe * Update to stable version * Fix changelog * Fix changelog
Description
It is still alpha (ref: typescript-eslint/typescript-eslint#5688 (comment)).Checklist
changelog_unreleased/*/XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨