Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport implementation of satisfies #13786

Closed
wants to merge 8 commits into from

Conversation

sosukesuzuki
Copy link
Member

Description

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker
Copy link
Sponsor Member

fisker commented Nov 3, 2022

Why not merge #13783 into this one? No wonder I didn't see any satisfies tests there.

@sosukesuzuki
Copy link
Member Author

Why not merge #13783 into this one? No wonder I didn't see any satisfies tests there.

Just for reviewing. #13783 includes changes that are not for satisfies. If the parser changes are not annoying to the reviewer, I can merge this into #13783.

@fisker
Copy link
Sponsor Member

fisker commented Nov 3, 2022

They already been reviewed. Let's merge them.

@sosukesuzuki
Copy link
Member Author

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants