Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for satisfies #13775

Merged
merged 5 commits into from Nov 2, 2022

Conversation

sosukesuzuki
Copy link
Member

Description

Follow up #13764

babel/babel#15095 has been fixed so we can add more tests for satisfies as LHS.

Checklist

Try the playground for this PR

@kachkaev
Copy link
Member

kachkaev commented Nov 1, 2022

Newlines missing on second pass?
https://github.com/prettier/prettier/actions/runs/3371313445/jobs/5593363953#step:6:1306

  ;(a satisfies number) = 42<LF>
  ;({ a: (b satisfies any) = 2000 } = x)<LF>
- <LF>
  ;(this.selectorElem satisfies any) =<LF>
    this.multiselectWidget =<LF>
    this.initialValues =<LF>
      undefined<LF>
- <LF>
  ;(this.configuration satisfies any) =<LF>
    (this.editor satisfies any) =<LF>
    (this.editorBody satisfies any) =<LF>
      undefined<LF>

@fisker
Copy link
Member

fisker commented Nov 1, 2022

Newlines missing on second pass?

Known issue for --no-semi, it's fine to ignore.

@fisker fisker merged commit 67e121a into prettier:next Nov 2, 2022
@sosukesuzuki sosukesuzuki deleted the add-more-tests-for-satisfies branch November 2, 2022 04:31
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants