New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several JSX fixes (addresses #73) #123
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
22aef7c
Wrap Stateless JSX Arrow Functions and Assignment in Parens (fixes pa…
rattrayalex 85a07d4
Break JSXOpeningElement between attributes (fixes #15)
rattrayalex 2552da5
JSX maintains spaces that matter (fixes #30 and thus part of #73)
rattrayalex 5075fa6
Multiline JSX opening tag breaks children out too (for #73)
rattrayalex eccf3d1
Add regression tests for long JSX Expression contents
rattrayalex File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlongster my
beginBreak
/endBreak
logic here felt a bit awkward – I'm adding asoftline
unless there's already a line. Is there a cleaner way to do that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rattrayalex Sorry I didn't review this until now.
I'm not entirely sure of the logic you're going for here, but is
util.newlineExistsBefore
helpful? If you're trying to emulate the breaking behavior in the original source, that andutil.newlineExistsAfter
allows you to peek into the original source and see if a node is on a newline or not. Here's how you use it:What this does is it scans backward until it hits either a newline or a non-whitespace character. If it hits a newline, it reports
true
, otherwise it'sfalse
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's definitely helpful to know about, though in this case I think the lines could be inserted by
prettier
, not just from the original source. So I think it wouldn't be adequate in this case.But it would be very helpful when deciding whether
{' '}
needs to be inserted, if that's a route we go.