Handle TypeScript 4.5 new file extensions .mts and .cts
#11721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosukesuzuki
commented
Oct 29, 2021
| since: "1.4.0", | ||
| parsers: ["typescript", "babel-ts"], | ||
| vscodeLanguageIds: ["typescript"], | ||
| extensions: [...data.extensions, ".mts", ".cts"], |
There was a problem hiding this comment.
We can remove this if .mts and .cts are added to linguist-language
There was a problem hiding this comment.
Do you think code blocks in markdown with language mts should use ts parser too?
There was a problem hiding this comment.
Yes. But honestly, I don't care either way...
There was a problem hiding this comment.
@fisker Do you have any concern for current implementation?
fisker
approved these changes
Oct 30, 2021
|
This is a feature for next minor version, but we probably never release patch release 2.4.x so I'll merge this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial of #11600
See https://devblogs.microsoft.com/typescript/announcing-typescript-4-5-beta/#new-file-extensions for details.
Checklist
docs/directory).✨Try the playground for this PR✨