Update typescript-estree to 5.x #11676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosukesuzuki
force-pushed
the
support-ts-estree-5
branch
4 times, most recently
from
0fd9a3e
to
6d8cd94
Compare
sosukesuzuki
commented
Oct 15, 2021
Comment on lines
+101
to
+113
| =====================================input====================================== | ||
| type Foo = | ||
| // prettier-ignore | ||
| ( | ||
| aa | ||
| ); | ||
|
|
||
| =====================================output===================================== | ||
| type Foo = | ||
| // prettier-ignore | ||
| aa; | ||
|
|
||
| ================================================================================ |
There was a problem hiding this comment.
TSParenthesizedType node is removed, so we cannot keep parens wrap types with prettier-ignore typescript-eslint/typescript-eslint#3340
sosukesuzuki
force-pushed
the
support-ts-estree-5
branch
from
6d8cd94
to
261507a
Compare
sosukesuzuki
changed the base branch from
dependabot/npm_and_yarn/typescript-eslint/typescript-estree-5.0.0
to
main
sosukesuzuki
changed the title
fisker
reviewed
Oct 20, 2021
| @@ -1,54 +1,18 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
Rename as postprocess/index.js ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #11668
Updates typescript-estree to 5.x.
Official release note
Notable changes:
TSParenthesizedTypenode.prettier-ignoreformatting will be broken. (Update typescript-estree to 5.x #11676 (comment))ClassPropertyis now calledPropertyDefinitionTSAbstractClassPropertyis now calledTSAbstractPropertyDefinitionTSAbstractPropertyDefinition.valueis now alwaysnullPrivateIdentifierTSPrivateIdentifier.Checklist
✨Try the playground for this PR✨