New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown[next branch]: Do not insert spaces between Chinese/Japanese & latin letters #11597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I do not have to add anything in changelog_unreleased/markdown/, I will change this to the normal (not draft) PR.
This PR needs changelog! Please add it.
a09c98c
to
a1d9b7e
Compare
@sosukesuzuki I added one. It may have wrong usage of English words. |
a1d9b7e
to
6457dcf
Compare
6457dcf
to
394b1d7
Compare
This is not compatible with the current CI (lint). The stable version must not be used to check my changelog. This contains “第1章” (means Chapter 1), which will be spoiled (2x U+0020 will be inserted) by it. I cannot help it. Line 90 in 04391a0
Line 131 in 04391a0
Line 141 in 04391a0
Line 156 in 04391a0
prettier/.github/workflows/lint.yml Lines 36 to 37 in 04391a0
|
I wish we could test code not only by |
Another plan is to use my patch plugin prettier-plugin-md-nocjsp to lint only my changelog. overrides:
- files:
- 11597.md
options:
parser: markdown-nocjsp |
394b1d7
to
8212b8e
Compare
https://github.com/prettier/prettier/pull/11597/checks?check_run_id=3918774427 Another new PR is required.
The current CI tries to use the stable version of Prettier to lint. |
8212b8e
to
073f7b6
Compare
Fixed by adding one more <!-- prettier-ignore -->
Adding whitespace may interfere with searches for text containing both Chinese or Japanese and western characters. For example, you cannot find “第1章” (Chapter 1) in a Markdown document or its derivative just by searching by the string “第1章” but “第 1 章”. |
Do I have to do this? |
Could you tell me what prevents this PR from merged? |
I think we are good to merge. Please be patient. We are still far from release v3 anyway. |
Great job! |
Thanks @tats-u ! Congrats with the end of this year-long journey. 🎉 |
Great job!!!! Thank you!! |
I’m glad to hear this! Great job!! |
Extremely great job!!! |
Truly great work. Thanks!! |
Thanks!! |
Is there an option to add whitespace between Chinese and Latin characters? |
No, there is no option for it, you can try https://github.com/lint-md/lint-md Locking this PR, since it's old. |
Description
This PR is for fixing #6385 in the coming version 3.0, and introduces the change in my hotfix plugin to the original Prettier.
Remove the option from and optimize #8526
Note: this is for the
next
branch, not themain
branch.If I do not have to add anything in
changelog_unreleased/markdown/
, I will change this to the normal (not draft) PR.Fixes #6385
Checklist
docs/
directory).changelog_unreleased/*/XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨
I just did
yarn jest --updateSnapshot
.P.S. (2022-12-11)
This patch is enabled in Prettier 3.0.0-alpha.3 or later.