Use regex instead of two includes methods
#11314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
reviewed
Aug 6, 2021
| @@ -105,7 +105,7 @@ function createParse(parseMethod, ...optionsCombinations) { | |||
| })); | |||
| } | |||
|
|
|||
| if (text.includes("#{") || text.includes("#[")) { | |||
| if (/#({|\[)/.test(text)) { | |||
There was a problem hiding this comment.
Suggested change
| if (/#({|\[)/.test(text)) { | |
| if (/#[[{]/.test(text)) { |
There was a problem hiding this comment.
I'm surprised that eslint-plugin-import didn't report
I thought #11013 already merged.
There was a problem hiding this comment.
Oh, I missed your review sorry. I want to review the PR, but I'm not familiar with regex.
fisker
approved these changes
Aug 6, 2021
fisker
changed the title
includes methods
sosukesuzuki
added a commit
to sosukesuzuki/prettier
that referenced
this pull request
Aug 6, 2021
sosukesuzuki
added a commit
that referenced
this pull request
Aug 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
✨Try the playground for this PR✨