Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable comment attach in babel parser #11313

Closed
wants to merge 1 commit into from

Conversation

fisker
Copy link
Member

@fisker fisker commented Aug 6, 2021

Description

Ref babel/babel#13229

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker
Copy link
Member Author

fisker commented Aug 6, 2021

This seems not easy to disable, we use leadingComments in parser's postprocess, I tried to move it into printer's preprocess, then it breaks comment attach... Maybe take a deep look another time.

@fisker fisker closed this Aug 6, 2021
@fisker fisker deleted the babel-comments branch November 12, 2021 17:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant