Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Change husky to simple-git-hooks #10601

Merged
merged 1 commit into from Mar 26, 2021
Merged

Conversation

toplenboren
Copy link
Contributor

@toplenboren toplenboren commented Mar 25, 2021

Description

Lint staged along with mrm recently migrated from husky to simple-git-hooks.

It is now reflected in their docs:

It will install and configure simple-git-hooks and lint-staged depending on code quality tools from package.json dependencies so please make sure you install (npm install --save-dev) and configure all code quality tools like Prettier, ESlint prior that.

Migration brought these benefits for users:

  • lighter node_modules
    simple-git-hooks (10 kb) is lighter then husky4 (1mb) and husky5 (25kb)
  • Out of the box Yarn 2 support
  • No worry for licensing.
    Simple git hooks has MIT license, like husky 4

P.S didn't check the checkboxes. Don't know If I should add challengelog for docs change :(

Checklist

  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

`Lint staged` along with `mrm` recently migrated from `husky` to `simple-git-hooks`.

It is reflected in their [docs](https://github.com/okonet/lint-staged):

> It will install and configure simple-git-hooks and lint-staged depending on code quality tools from package.json dependencies so please make sure you install (npm install --save-dev) and configure all code quality tools like Prettier, ESlint prior that.

Migration brought these benefits for users: 

* lighter `node_modules` 
   `simple-git-hooks` (10 kb) is lighter then husky4 (1mb) and husky5 (25kb)
* Out of the box `Yarn 2` support
* No worry for licensing. 
   Simple git hooks has MIT license, like husky 4
@thorn0 thorn0 merged commit 7678033 into prettier:main Mar 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants