Ember / Handlebars: Do not break opening mustache and path

[dcyriller]

Description

In Ember ecosystem, the opening mustache and the path are often printed on a same line (see this comment and this comment for more details).

Changes

{{!-- Input --}}
<GlimmerComponent
  @errors={{or this.aVeryLongProperty (and this.aProperty (v-get bike "number" "message"))}}
  data-test-beneficiary-account-number
/>
<GlimmerComponent
  @progress={{aPropertyEngdingAfterEightiethColumnToHighlightAWeirdClosingParenIssue}}
/>

{{!-- Prettier stable --}}
<GlimmerComponent
  @errors={{
    or
    this.aVeryLongProperty
    (and this.aProperty (v-get bike "number" "message"))
  }}
  data-test-beneficiary-account-number
/>
<GlimmerComponent
  @progress={{
    aPropertyEngdingAfterEightiethColumnToHighlightAWeirdClosingParenIssue
  }}
/>

{{!-- Prettier main --}}
<GlimmerComponent
  @errors={{or
    this.aLongProperty
    (and this.aProperty (v-get bike "number" "message"))
  }}
  data-test-beneficiary-account-number
/>
<GlimmerComponent
  @progress={{aPropertyEngdingAfterEightiethColumnToHighlightAWeirdClosingParenIssue}}
/>

Checklist

• I’ve added tests to confirm my change works.
• (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
• (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
• I’ve read the contributing guidelines.

✨Try the playground for this PR✨

[thorn0]

Will this close #8691?

[dcyriller]

It only covers a part of it

[thorn0]

Please add test cases from that issue. If you want, you can prefix the test files' names with issue-8691 (e.g. issue-8691-if-1.hbs). I usually do that when I collect test cases from issues..

[dcyriller]

Please add test cases from that issue. If you want, you can prefix the test files' names with issue-8691 (e.g. issue-8691-if-1.hbs). I usually do that when I collect test cases from issues..

I have a follow-up PR ready for the linked issue. Do you mind if I apply this comment to the follow-up PR?

Indeed, I split the work in two PRs to have two different changelog entries. (So that it is clearer for the end user.) But if you prefer I can merge them. Let me know!

[thorn0]

two different changelog entries. (So that it is clearer for the end user

This is a good idea. I meant only those test cases that this PR improves. Not all the test cases from that issue.

[dcyriller]

I have added test cases taken from #8691 (it won't close the issue though) and rebased to highlight the difference (all commits are supposed to pass the CI).

[thorn0]

Wrapping the closing }} like this looks unexpected.

Prettier pr-10586
Playground link

--parser glimmer
--print-width 90

Input:

<GlimmerComponent
  @errors={{or this.aVeryLongProperty (and this.aProperty (v-get bike "number" "message"))}}
  data-test-beneficiary-account-number
/>

Output:

<GlimmerComponent
  @errors={{or this.aVeryLongProperty (and this.aProperty (v-get bike "number" "message"))
  }}
  data-test-beneficiary-account-number
/>

[dcyriller]

nice catch - I pushed some changes (they specifically adress the issue reported in this comment)