Force else to break before anything inside it (fixes #616)

[jlongster]

This is a more appropriate fix than #680. The problem is described more in #680 (comment). The only solution I can think of is to be very careful when objects are expanded. They can be naturally wrapped in the first pass, but the second one will see hard breaks and break everything above it. For the most part, that behavior is identical, but there are a few cases like this one where it wasn't breaking the code around it first.

This changes that and creates a new group that will break before the object breaks. That will force it to add the newline and stabilizes the output.

[vjeux]

<3

Thanks for looking into it!

[jlongster]

No problem!

Just realized the if part is now unstable, whoops. Need to play with this a little bit more.

[jlongster]

So this is the only way to fix it. We need to create separate groups for the if and else parts so that they can break separately. It's the only way I can think to make the object expansion match in both places.

The core problem is the conditionalGroup which suppressed the hardline. It's a pattern we need to avoid, unfortunately. Suppressing that hard line means the measurer won't break the if/else expression but will break things inside of it.

I think this should be OK in real-world code. Hopefully it doesn't change too much code but I think it's pretty rare to mix bracket and no-bracket styles.

[vjeux]

One less conditional group <3

I do think that it's rare enough to have both use a different bracket/no-bracket that we shouldn't support this use case.