New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Add rollup-plugin-polyfill-node
#10249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: bundle size diff main
vs fisker:rollup-plugin-node-polyfills
index.js........................................................1.7 MB DONE
doc.js..........................................................125 kB DONE
-standalone.js...................................................522 kB DONE
+standalone.js...................................................529 kB DONE
bin-prettier.js.................................................448 kB DONE
third-party.js..................................................290 kB DONE
-parser-babel.js.....................................348 kB, esm 347 kB DONE
+parser-babel.js.....................................348 kB, esm 348 kB DONE
parser-flow.js....................................3.09 MB, esm 3.09 MB DONE
-parser-typescript.js..............................3.08 MB, esm 3.08 MB DONE
-parser-espree.js....................................224 kB, esm 224 kB DONE
-parser-meriyah.js...................................196 kB, esm 196 kB DONE
-parser-angular.js.................................88.1 kB, esm 87.9 kB DONE
+parser-typescript.js..............................3.09 MB, esm 3.09 MB DONE
+parser-espree.js....................................225 kB, esm 225 kB DONE
+parser-meriyah.js...................................197 kB, esm 197 kB DONE
+parser-angular.js.................................88.1 kB, esm 87.8 kB DONE
parser-postcss.js...............................................227 kB DONE
-esm/parser-postcss.mjs..........................................236 kB DONE
+esm/parser-postcss.mjs..........................................213 kB DONE
parser-graphql.js.................................55.5 kB, esm 55.2 kB DONE
-parser-markdown.js..................................154 kB, esm 153 kB DONE
+parser-markdown.js..................................179 kB, esm 179 kB DONE
parser-glimmer.js...................................169 kB, esm 169 kB DONE
parser-html.js......................................162 kB, esm 161 kB DONE
parser-yaml.js......................................144 kB, esm 144 kB DONE
The bundle size will increase a little, but I think it doesn't matter.
Size changed because we are using simple I think the size increase is acceptable. |
Description
rollup-plugin-node-globals
is blocking us use new syntax, rollup/rollup#2881Checklist
docs/
directory).changelog_unreleased/*/XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨