Handlebars: fix formatting of attributes #10145
Conversation
thorn0
force-pushed
the
handlebars-attrs
branch
from
2a393a6
to
4f3ac2a
Compare
| @@ -204,8 +254,6 @@ function print(path, options, print) { | |||
| const [lead] = n.chars.match(leadingWhitespacesRE); | |||
There was a problem hiding this comment.
| const [lead] = n.chars.match(leadingWhitespacesRE); | |
| const [lead] = text.match(leadingWhitespacesRE); |
There was a problem hiding this comment.
also on lines 295:299 (can't suggest there)
| @@ -204,8 +254,6 @@ function print(path, options, print) { | |||
| const [lead] = n.chars.match(leadingWhitespacesRE); | |||
| const [tail] = n.chars.match(trailingWhitespacesRE); | |||
There was a problem hiding this comment.
| const [tail] = n.chars.match(trailingWhitespacesRE); | |
| const [tail] = text.match(trailingWhitespacesRE); |
| return [quote, stringLiteral.replace(regex, `\\${quote}`), quote]; | ||
| } | ||
|
|
||
| function chooseEnclosingQuote(options, stringLiteral) { |
| @@ -0,0 +1,25 @@ | |||
| #### Fix formatting of attributes (#10145 by @thorn0) | |||
|
|
|||
| - fix escaping of `{{` in attributes and text | |||
There was a problem hiding this comment.
nice catch, I had this refactor / fix on a branch too
What can be reused should definitely be reused, but we need to figure out a way to share that code between the two printers. Currently |
|
@dcyriller Just realized that I was wrong here:
Only the parsers are extracted to separate bundles. The printers all go in one bundle, so it's okay to |
Description
This PR
{{in attributes and text'and"for attributes with interpolations[object Object]printed inclassclass, like in HTML in the current stable version (before Smarter formatting of HTML class attribute #7865)Closes #8648
Closes #8667
cc @dcyriller @kangax
Checklist
changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨